D13629: Fix crashing devicetest

Nicolas Fella noreply at phabricator.kde.org
Wed Jun 20 12:25:51 UTC 2018


nicolasfella created this revision.
nicolasfella added a reviewer: KDE Connect.
Restricted Application added a project: KDE Connect.
Restricted Application added a subscriber: kdeconnect.
nicolasfella requested review of this revision.

REVISION SUMMARY
  When running the test m_impl will be nullptr leading to a crash. This is because when running as a test no platform is loaded.
  The fancy way to solve this would be to have a TestImpl, but I think this is enough.

TEST PLAN
  The test still does not pass, but I belive this is a unrelated issue.

REPOSITORY
  R224 KDE Connect

BRANCH
  fixtest

REVISION DETAIL
  https://phabricator.kde.org/D13629

AFFECTED FILES
  plugins/mousepad/mousepadplugin.cpp

To: nicolasfella, #kde_connect
Cc: kdeconnect, #kde_connect, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180620/98db59bc/attachment.html>


More information about the KDEConnect mailing list