D13503: Enable running commands from app

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> remotecommandsmodel.h:68
> +    RemoteCommandsDbusInterface* m_dbusInterface;
> +    QVector<Command*> m_commandList;
> +    QString m_deviceId;

Just QVector<Command>. It will make the code slightly simpler.

> kdeconnectdeclarativeplugin.cpp:97
>      qmlRegisterType<NotificationsModel>(uri, 1, 0, "NotificationsModel");
> +    qmlRegisterType<RemoteCommandsModel>(uri, 1, 0, "RemotecommandsModel");
>      qmlRegisterType<DBusAsyncResponse>(uri, 1, 0, "DBusAsyncResponse");

I would always write upper-case C on RemoteCommands.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D13503

To: nicolasfella, #kde_connect, apol
Cc: apol, kdeconnect, #kde_connect, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180614/30cae85c/attachment-0001.html>