D13503: Enable running commands from app

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> apol wrote in remotecommand.h:30
> Wouldn't it make sense to just return a QVariantMap or QJsonObject? Creating a dbus interface just to make it constant doesn't make a lot of sense.

I thought about that too when it was already too late. This way we already expose the parsed data, otherwise we would need to do that in the model (which would be fine). But the current approach would be beneficial if something else would use the DBus interface (some hypothetical extra UI) so we don't need to implement the parsing twice.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D13503

To: nicolasfella, #kde_connect
Cc: apol, kdeconnect, #kde_connect, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180613/5f33311b/attachment.html>