T7994: Extract Qt Pulseaudio bindings into a Framework
Harald Sitter
noreply at phabricator.kde.org
Wed Jun 13 10:45:40 UTC 2018
sitter added a comment.
Random complaints I stumbled upon:
- `m_context = pa_context_new(api, "QPulse");` this should decidedly not hardcode `QPulse` but use https://doc.qt.io/qtthe-5/qcoreapplication.html#applicationName-prop (or maybe even displayName iff qapp can be cast to qguiapplication)
- along the same notion, Context should probably have a function `setName` for `pa_context_set_name` in case the qapp name isn't the desired name (e.g. with a plasmoid the qapp is plasma, but the app name should probably be the individual plasmoid)
TASK DETAIL
https://phabricator.kde.org/T7994
To: nicolasfella, sitter
Cc: davidedmundson, michaelh, akrutzler, apol, sitter, drosca, #kde_connect, nicolasfella, jdvr, yannux, Danial0_0, johnq, ragreen, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, ZrenBot, seebauer, ngraham, bruns, bugzy, MayeulC, menasshock, lesliezhai, ali-mohamed, jensreuterberg, ach, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180613/e26e2c50/attachment.html>
More information about the KDEConnect
mailing list