D13447: Use kdeconnect:// url to trigger commands

[Albert Vaca Cintora]

albertvaka accepted this revision.
albertvaka added a comment.
This revision is now accepted and ready to land.


  The command IDs are quite ugly because they contain "{" which are not safe on URLs. This patch is fine, though, we can change it by changing the generation of those IDs on the desktop side, so they don't have these braces (only for newly-generated IDs).
  
  Eg of a runcommand URI:
   `kdeconnect://runcommand/_b5e53f8d_0fc6_47f4_9fcc_3bae11da8a0b_/{c3c1cbbe-e182-4ae6-a451-21cf3ff39d79}`

INLINE COMMENTS

> RunCommandUrlActivity.java:68
> +    void error(int message) {
> +        TextView view = new TextView(this);
> +        view.setText(message);

Maybe a toast is enough?

REPOSITORY
  R225 KDE Connect - Android application

BRANCH
  nfc

REVISION DETAIL
  https://phabricator.kde.org/D13447

To: nicolasfella, #kde_connect, albertvaka
Cc: albertvaka, apol, kdeconnect, #kde_connect, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180726/95158e63/attachment-0001.html>