D7993: System volume plugin Android

[Albert Vaca Cintora]

albertvaka accepted this revision.
albertvaka added a comment.


  I suggest a small change, but it looks good. It's fine to merge this now and we can make the change later if you want.

INLINE COMMENTS

> SystemvolumePlugin.java:37
> +
> +    private final static String PACKET_TYPE_SYSTEMVOLUME = "kdeconnect.systemvolume";
> +

Since the packets you send and the packets you receive are not symmetrical (you receive packets that have a 'sinkList' but you send packets that have, for example a 'name' and 'volume', and they are never interchangeable), I think we should split the type in two (like it is done in other asymmetrical plugins).

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D7993

To: nicolasfella, #kde_connect, mtijink, albertvaka
Cc: albertvaka, MatMaul, kdeconnect, Murz, mtijink, #kde_connect, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180726/b676164f/attachment.html>