D12507: Added runcommandplugin widget

[Albert Vaca Cintora]

albertvaka accepted this revision.
albertvaka added a comment.


  Looks cool, thanks!
  
  I just have a small improvement suggestion: the device selected by default is the first in the list, even if it's not paired. If there are paired devices, you could select by default the first *paired* device. You can't select a device that is not paired after clicking the device name anyway, so it should not be selected by default.
  
  Another nitpicky thing: maybe the title bar could be smaller? It takes up some real state that could be used for the actual command list.
  
  Apart from these, it looks very good. Let me know if/when you make this changes and want to get this merged, since I see you don't have commit rights.

REVISION DETAIL
  https://phabricator.kde.org/D12507

To: menasshock, albertvaka, #kde_connect, nicolasfella
Cc: kdeconnect, nicolasfella, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180726/efea6833/attachment.html>