D10703: Build kdeconnect on sailfish and port some simple plugins

[Aleix Pol Gonzalez]

apol added a comment.


  I'd clean up the patch first but it looks good to me overall.

INLINE COMMENTS

> CMakeLists.txt:3
>  
> +find_package(KF5 REQUIRED COMPONENTS Notifications KIO)
> +

This is already being searched in the parent directory. This file is not parsed when on sailfishos.

> CMakeLists.txt:4
> +find_package(KF5 REQUIRED COMPONENTS Notifications KIO)
> +
>  add_definitions(-DTRANSLATION_DOMAIN="kdeconnect-kded")

Please remove just new lines.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D10703

To: piggz, #kde_connect, apol, mtijink, nicolasfella, albertvaka
Cc: kdeconnect, andyholmes, albertvaka, kossebau, mtijink, vonreth, apol, #kde_connect, nicolasfella, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180725/3f949e3e/attachment.html>