D10089: Fix crash in NotificationsPlugin

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> notification.cpp:35
>  
> +QMutex* Notification::m_mutex = new QMutex();
> +

Never deleted.

> notification.cpp:113
>  
> +    m_mutex->lock();
>      if (!m_hasIcon) {

It will make a deadlock if loadIcon does not get called i.e. applyNoIcon or applyIcon

REPOSITORY
  R224 KDE Connect

BRANCH
  notifix

REVISION DETAIL
  https://phabricator.kde.org/D10089

To: tfella, #kde_connect, nicolasfella, albertvaka
Cc: anthonyfieroni, #kde_connect, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, tfella, aboudhar, seebauer, bugzy, progwolff, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180125/0b0df963/attachment.html>