D10089: Fix crash in NotificationsPlugin

[Tobias Fella]

tfella created this revision.
tfella added reviewers: KDE Connect, nicolasfella.
tfella added a project: KDE Connect.
tfella requested review of this revision.

REVISION SUMMARY
  When running Spotify on the desktop and phone simultaneously the playback notification gets updated multiple times very fast. This leads to a crash in the notificationsplugin because the notification is updated before it's actually added to the list. This leads to the icon not being transfered correctly and crashes.
  Added a mutex to prevent concurrent access to the tmp file.

TEST PLAN
  Run Spotify on Desktop and phone. Restart Spotify phone app. Doesn't crash any more.

REPOSITORY
  R224 KDE Connect

BRANCH
  notifix

REVISION DETAIL
  https://phabricator.kde.org/D10089

AFFECTED FILES
  plugins/notifications/notification.cpp
  plugins/notifications/notification.h

To: tfella, #kde_connect, nicolasfella
Cc: #kde_connect, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, tfella, aboudhar, seebauer, bugzy, progwolff, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180124/07aae187/attachment.html>