D7959: Make it possible to add commands for the RunCommandsPlugin from Android

Matthijs Tijink noreply at phabricator.kde.org
Wed Jan 17 19:56:10 UTC 2018


mtijink requested changes to this revision.
mtijink added a comment.
This revision now requires changes to proceed.


  Looks good! Can be merged, as far as I'm concerned, after the fix for the crash.

INLINE COMMENTS

> activity_runcommand.xml:26
> +        app:layout_anchorGravity="bottom|end"
> +        android:backgroundTint="@color/primary" />
> +

Needs to be `app:backgroundTint` or it crashes for me.

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D7959

To: nicolasfella, #kde_connect, mtijink
Cc: mtijink, #kde_connect, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, tfella, aboudhar, seebauer, bugzy, progwolff, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180117/57f5a00b/attachment.html>


More information about the KDEConnect mailing list