D9690: Add first-cut contacts-reading plugin

Simon Redman noreply at phabricator.kde.org
Mon Jan 15 02:29:50 UTC 2018


sredman added inline comments.

INLINE COMMENTS

> mtijink wrote in ContactsPlugin.java:236
> Maybe better to move this check to the beginning of the function: that improves readability and reduces indenting.

On thinking more about it, I want to be able to check against many types of packets, so having helper methods for each different type is a better way to clean this up. I have started implementing this.

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D9690

To: sredman, kdeconnect
Cc: mtijink
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180115/8cbcf34a/attachment.html>


More information about the KDEConnect mailing list