D7959: Make it possible to add commands for the RunCommandsPlugin from Android

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> mtijink wrote in AddCommandDialog.java:39
> Would it be possible to disable the `ok` button while either input field is still empty?

In theory, yes, but I couldn't make it work perfectly. Also the button has no visual feedback whether it's disabled or not

> mtijink wrote in RunCommandPlugin.java:141
> So if the desktop does not support remotely adding commands, the (empty) activity still appears, without anything to do. Can we hide it in that case, or add a text displaying how to add commands on the desktop?

My reason to unhide it was to show users that this functionality exists, The text is a great idea

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D7959

To: nicolasfella, #kde_connect
Cc: mtijink, #kde_connect, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, tfella, aboudhar, seebauer, bugzy, progwolff, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180114/9d1c5699/attachment.html>