D9621: Restrict access modifiers to the necessary

Matthijs Tijink noreply at phabricator.kde.org
Wed Jan 3 19:25:11 UTC 2018


mtijink added inline comments.

INLINE COMMENTS

> RepliableNotification.java:11
> +class RepliableNotification {
>      public String id = UUID.randomUUID().toString();
> +    PendingIntent pendingIntent;

Why does the `id` need to remain public?

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D9621

To: nicolasfella, #kde_connect
Cc: mtijink, #kde_connect, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, tfella, aboudhar, seebauer, bugzy, progwolff, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180103/02498f21/attachment.html>


More information about the KDEConnect mailing list