D10703: Build kdeconnect on sailfish and port some simple plugins

[Nicolas Fella]

nicolasfella added a comment.


  Thanks for working on this!

INLINE COMMENTS

> device.cpp:46
> +#ifdef SAILFISHOS
> +#define qAsConst
> +#endif

Does that really solve the issue?

> CMakeLists.txt:4
> +if (SAILFISHOS)
> +    pkg_check_modules(NNQT5 REQUIRED nemonotifications-qt5)
> +    include_directories(${NNQT5_INCLUDE_DIRS})

Could Nemo Notifications replace KNotifications entirely?

> kdeconnectd.cpp:47
>  
>  class DesktopDaemon : public Daemon
>  {

We could split this into DesktopDaemon and SailfishDaemon

> kdeconnectdeclarativeplugin.h:29
>      Q_OBJECT
> -
> +#if SAILFISHOS
> +public:

Can we remove the condition?

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D10703

To: piggz, #kde_connect
Cc: nicolasfella
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180221/80d54a8f/attachment.html>