D10332: Allow choosing a ringtone for FindMyPhone

[Matthijs Tijink]

mtijink added a comment.


  The code looks good to me (didn't test yet though).
  
  The change is small and it actually helps some users, so I'd say this is ok. Shipping our own sound would work too, but I think that actually matters a lot.

REPOSITORY
  R225 KDE Connect - Android application

BRANCH
  findmyphone

REVISION DETAIL
  https://phabricator.kde.org/D10332

To: nicolasfella, #kde_connect, albertvaka
Cc: mtijink, andyholmes, albertvaka, apol, #kde_connect, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, tfella, aboudhar, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180218/20e7fa1c/attachment.html>