D9266: Add MPRIS media control notification
Nicolas Fella
noreply at phabricator.kde.org
Wed Feb 14 20:27:34 UTC 2018
nicolasfella added a comment.
In D9266#178775 <https://phabricator.kde.org/D9266#178775>, @mtijink wrote:
> In D9266#178720 <https://phabricator.kde.org/D9266#178720>, @nicolasfella wrote:
>
> > Works well so far :) Some small things I noticed: Toggling the option doesn't activate/deactivate the notification immediately.
>
>
> I know (should have mentioned that, though). It's because the plugin doesn't reload and doesn't get notified in any way of the preference change. I figured that this is the simplest solution, as the notification appears/disappears on the next track/device/player list changes. In general, I think it's good if the plugin can be notified of such changes, or automatically reloads, but I think that's out of scope for this diff.
Maybe https://developer.android.com/guide/topics/ui/settings.html#ReadingPrefs can help :)
REPOSITORY
R225 KDE Connect - Android application
REVISION DETAIL
https://phabricator.kde.org/D9266
To: mtijink, #kde_connect
Cc: apol, albertvaka, nicolasfella
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180214/56c1ae5c/attachment.html>
More information about the KDEConnect
mailing list