D17841: Workaround for bluetooth payload transfer bugs
Matthijs Tijink
noreply at phabricator.kde.org
Fri Dec 28 18:47:34 GMT 2018
mtijink created this revision.
mtijink added a reviewer: KDE Connect.
Herald added a project: KDE Connect.
Herald added a subscriber: kdeconnect.
mtijink requested review of this revision.
REVISION SUMMARY
On both devices I tested, the bluetooth InputStream did not notice end-of-stream and thus the transfer hanged.
Using this workaround, if we know the size of the payload, we notice this condition and prevent reading too much.
If this happens on all devices, we could possibly cancel the transfer immediately instead of only logging.
TEST PLAN
Transferring files or media art now works correctly.
REPOSITORY
R225 KDE Connect - Android application
BRANCH
bluetooth-android-download-workaround
REVISION DETAIL
https://phabricator.kde.org/D17841
AFFECTED FILES
src/org/kde/kdeconnect/Backends/BluetoothBackend/BluetoothLink.java
src/org/kde/kdeconnect/Helpers/LimitedInputStream.java
To: mtijink, #kde_connect
Cc: kdeconnect, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181228/a82c198d/attachment.html>
More information about the KDEConnect
mailing list