D17702: [mpriscontrol] add primitive windows support

[Albert Vaca Cintora]

albertvaka accepted this revision.
albertvaka added a comment.
This revision is now accepted and ready to land.


  Looks good to me.

INLINE COMMENTS

> mpriscontrolplugin-win.cpp:23
> +    const QString player = np.get<QString>(QStringLiteral("player"));
> +    const QList<QString> playerlist = {playername};
> +    bool valid_player = (player == playername);

Can be defined inside the if.

REPOSITORY
  R224 KDE Connect

BRANCH
  windows-mpriscontrol

REVISION DETAIL
  https://phabricator.kde.org/D17702

To: jambon, kdeconnect, #kde_connect, albertvaka
Cc: albertvaka, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, sdepiets, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, kfunk, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181221/f171fd7f/attachment.html>