D17628: Do not close m_socket in socketError()

[Erik Duisters]

eduisters created this revision.
Herald added a project: KDE Connect.
Herald added a subscriber: kdeconnect.
eduisters requested review of this revision.

REVISION SUMMARY
  When android closes the payload socket (cancel share) calling m_socket.close() results
  in a recursive call to onError eventually leading to a segmentation violation

TEST PLAN
  Install Dxxxx, share a large file from desktop to android and cancel the share on Android through
   the notification. kdeconnectd crashes almost 100% of the time. (It doesn't crash when it detects
   a disconnect in sendNextPacket)

REPOSITORY
  R224 KDE Connect

BRANCH
  crash_while_uploading_and_remote_closes_socket

REVISION DETAIL
  https://phabricator.kde.org/D17628

AFFECTED FILES
  core/backends/lan/compositeuploadjob.cpp

To: eduisters
Cc: kdeconnect, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181216/56878a41/attachment.html>