D17614: [SMS App] Improve filter

[Simon Redman]

sredman created this revision.
sredman added a reviewer: KDE Connect.
Herald added a project: KDE Connect.
Herald added a subscriber: kdeconnect.
sredman requested review of this revision.

REVISION SUMMARY
  - Allow filter box to handle keystrokes passed to the ListView
    - This is a little cheesy, but fixes T8341 <https://phabricator.kde.org/T8341>
  
  - Pin filter box to always be visible
  
  - Clear filter on Esc

TEST PLAN
  - Try typing a contact you would like to search for
    - Before: Every time you type a new letter, the filter box would lose focus and you would have to click it to give it focus again
    - Now: You can type smoothly
  
  - Try scrolling the list
    - Before: The filter box disappeared off the top of the screen
    - Now: The filter box is always visible
  
  - Try pressing escape
    - Before: Nothing
    - Now: Filter clears
  
  - Bonus: When using the arrow keys to navigate, before the filter was manually handling those and the view would not loop. Now, the view loops if you try to select an item past the beginning or end (Easiest to see with highlighting from D17612 <https://phabricator.kde.org/D17612>)

REPOSITORY
  R224 KDE Connect

BRANCH
  smsapp-filter

REVISION DETAIL
  https://phabricator.kde.org/D17614

AFFECTED FILES
  smsapp/qml/ConversationList.qml

To: sredman, #kde_connect
Cc: kdeconnect, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181216/b38519c6/attachment.html>