D17572: Add dependency on kirigami to SMS app

Simon Redman noreply at phabricator.kde.org
Thu Dec 13 20:53:19 GMT 2018


sredman added a subscriber: apol.
sredman added inline comments.

INLINE COMMENTS

> ConversationDisplay.qml:22
>  import QtQuick 2.1
> -import QtQuick.Controls 2.4
> +import QtQuick.Controls 2.2
>  import QtQuick.Layouts 1.1

@apol Please lend your QML experience:

- Do you know why the app on master is currently set to require QQC v2.4?
- If I change the version of a QML library and the app launches and runs correctly, does that mean everything is fine?

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D17572

To: sredman, #kde_connect
Cc: apol, kdeconnect, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181213/c4e89d4d/attachment.html>


More information about the KDEConnect mailing list