D16475: [SMS App] Make requestMoreMessages asynchronous, blocking, and caching

[Albert Vaca Cintora]

albertvaka accepted this revision.
albertvaka added a comment.


  I don't like the fact that we block waiting on a packet, but it's better to move this forward anyway. If it becomes a problem we can revise it later.

INLINE COMMENTS

> conversationmodel.cpp:54
>      clear();
> -    if (!threadId.isEmpty()) {
> -        m_conversationsInterface->requestConversation(threadId, 0, 10);
> +    if (!(threadId == INVALID_THREAD_ID)) {
> +        requestMoreMessages();

!=

> conversationmodel.cpp:95
>  
> -    if (!(message.threadID() == m_threadId.toInt())) {
> +    if (!(message.threadID() == m_threadId)) {
>          // Because of the asynchronous nature of the current implementation of this model, if the

!=

> conversationmodel.cpp:124
>  
> -    if (!(message.threadID() == m_threadId.toInt())) {
> +    if (!(message.threadID() == m_threadId)) {
>          // If a conversation which we are not currently viewing was updated, discard the information

!=

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16475

To: sredman, #kde_connect, nicolasfella, albertvaka
Cc: albertvaka, apol, nicolasfella, kdeconnect, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181212/54a0a9b2/attachment.html>