D17250: Fixed Header in 3 plugin pages: Run Command, Multimedia control, Remote input

Nicolas Fella noreply at phabricator.kde.org
Mon Dec 10 19:01:33 GMT 2018


nicolasfella added a comment.


  In D17250#374909 <https://phabricator.kde.org/D17250#374909>, @sredman wrote:
  
  > In D17250#374887 <https://phabricator.kde.org/D17250#374887>, @brute4s99 wrote:
  >
  > > Updated the diff to reflect just the relevant changes for this commit.
  >
  >
  > Looks good from this point of view. Thanks!
  >
  > @nicolasfella, do you know whether changing the names of the strings in strings.xml will mess up the translators? If so, we should probably not touch those. It will make our code a little strange but it would save a lot of hassle on their end.
  
  
  I don't know for sure if it will cause problems, but just to be sure I'd not change the translated files

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D17250

To: brute4s99, #kde_connect, sredman
Cc: nicolasfella, albertvaka, sredman, kdeconnect, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181210/4f0957e0/attachment-0001.html>


More information about the KDEConnect mailing list