D17400: Make toast work from a background threat
Erik Duisters
noreply at phabricator.kde.org
Fri Dec 7 11:00:38 GMT 2018
eduisters created this revision.
eduisters added a reviewer: KDE Connect.
Herald added a project: KDE Connect.
Herald added a subscriber: kdeconnect.
eduisters requested review of this revision.
REVISION SUMMARY
When receiving a text share an attempt is made to show a toast but that results
in an exception because the issuing threat is not running a looper.
TEST PLAN
Without this patch applied Share a text with an android device using the plasmoid
Result: No toast is displayed and in logcat you will get a:
java.lang.RuntimeException: Can't toast on a thread that has not called Looper.prepare() exception
With this patch applied again Share a text an android device using the plasmoid
Result: The toast is actually displayed even when the activity is not in the foreground
REPOSITORY
R225 KDE Connect - Android application
BRANCH
make_toast_work
REVISION DETAIL
https://phabricator.kde.org/D17400
AFFECTED FILES
src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java
To: eduisters, #kde_connect
Cc: kdeconnect, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181207/77477642/attachment.html>
More information about the KDEConnect
mailing list