D15108: Sort Cached Messages

[Simon Redman]

sredman marked 2 inline comments as done.
sredman added inline comments.

INLINE COMMENTS

> apol wrote in conversationsdbusinterface.h:86
> I wouldn't call it a list if it's not a list.
> Also would it make sense to have the timestamp in ConversationMessage?

The timestamp is a field of ConversationMessage already. It feels kind of dumb to store it twice like this, but it is very easy to do it this way...

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D15108

To: sredman
Cc: apol, nicolasfella, kdeconnect, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180829/89c074c8/attachment.html>