D15108: Sort Cached Messages

[Simon Redman]

sredman created this revision.
Herald added a project: KDE Connect.
Herald added a subscriber: kdeconnect.
sredman requested review of this revision.

REVISION SUMMARY
  Previously, incoming messages were appened to a QList. This list was accidentally sorted because that's how Android returned them, but new messages were appended to the wrong end of the list. This patch specifically and intentionally sorts messages so new ones become visible

TEST PLAN
  - Open SMS GUI, verify that the most-recent messages are shown
  - Either send or recieve an SMS
  - Wait about 5s (I do not know why this is necessary. Probably some Android weirdness)
  - De-select the current conversation, then re-select it
    - TODO: Make the app automatically respond to new messages
  - The newly sent or recieved message should be shown in the most-recent position

REPOSITORY
  R224 KDE Connect

BRANCH
  sms-message-sorting

REVISION DETAIL
  https://phabricator.kde.org/D15108

AFFECTED FILES
  plugins/telephony/conversationsdbusinterface.cpp
  plugins/telephony/conversationsdbusinterface.h

To: sredman
Cc: kdeconnect, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180828/6ac20ba6/attachment.html>