D15100: Add "KDE Connect Devices" link to remote:/ (Network) folder

Elvis Angelaccio noreply at phabricator.kde.org
Mon Aug 27 21:49:10 BST 2018


elvisangelaccio added a comment.


  +1 otherwise
  
  (and imho MTP doesn't really belong to "Network").

INLINE COMMENTS

> CMakeLists.txt:22
>  install(FILES kdeconnect.protocol DESTINATION ${SERVICES_INSTALL_DIR})
> +install(FILES kdeconnect-network.desktop DESTINATION ${DATA_INSTALL_DIR}/remoteview)

`DATA_INSTALL_DIR` is deprecated, we should use `KDE_INSTALL_DATADIR` instead.

> kdeconnect-network.desktop:4
> +Name=KDE Connect Devices
> +Open=false
> +Type=Link

What's this used for? It's not part of the desktop entry spec, can we drop it?

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D15100

To: broulik, apol, albertvaka, #vdg, elvisangelaccio
Cc: ngraham, kdeconnect, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180827/20896d1d/attachment.html>


More information about the KDEConnect mailing list