D14720: Add acceleration to remote input cursor

Chansol Yang noreply at phabricator.kde.org
Mon Aug 13 20:49:01 BST 2018


chansolyang added inline comments.

INLINE COMMENTS

> albertvaka wrote in PointerAccelerationProfileFactory.java:19
> I don't like this making an allocation every frame... Maybe you can change it so it's not needed? Eg: Making accumulatedX and accumulatedY public, and adding a resetMouseDelta() function to set them to zero, or allocating a single MouseDelta and reusing that one.
> 
> What do you think?

I'm not sure if allocating a tiny object every frame would be that much of a performance hit, but that's a fair point.
I've updated the code so that the MouseDelta objects will be reused.

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D14720

To: chansolyang, #kde_connect
Cc: albertvaka, kdeconnect, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180813/41b84d69/attachment.html>


More information about the KDEConnect mailing list