D14568: Fixup the sfos mpris control

Aleix Pol Gonzalez noreply at phabricator.kde.org
Sun Aug 12 10:20:52 BST 2018


apol added inline comments.

INLINE COMMENTS

> piggz wrote in mpris.qml:37
> where is the declarative api defined?

I mean it's usually better to do: 
`value: something.value` than the whole `onCompleted: value = something.value` and `onSomethingValueChanged: value = something.value`.

Not that you need to use a different library or something.

REPOSITORY
  R224 KDE Connect

BRANCH
  sfos-mpris-cleanup

REVISION DETAIL
  https://phabricator.kde.org/D14568

To: piggz, #kde_connect, nicolasfella, kossebau, albertvaka
Cc: albertvaka, apol, kdeconnect, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180812/5e55e3f8/attachment.html>


More information about the KDEConnect mailing list