D14720: Add acceleration to remote input cursor

[Albert Vaca Cintora]

albertvaka added a comment.


  Thanks a lot for implementing this! Moving the cursor now feels really good. My perfect config is with sensitivity: "above default" and acceleration: "weaker" :)
  
  I've added a comment inline with one thing I would change.

INLINE COMMENTS

> PointerAccelerationProfileFactory.java:19
> +        public MouseDelta commitAcceleratedMouseDelta() {
> +            MouseDelta res = new MouseDelta(accumulatedX, accumulatedY);
> +            accumulatedY = 0;

I don't like this making an allocation every frame... Maybe you can change it so it's not needed? Eg: Making accumulatedX and accumulatedY public, and adding a resetMouseDelta() function to set them to zero, or allocating a single MouseDelta and reusing that one.

What do you think?

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D14720

To: chansolyang, #kde_connect
Cc: albertvaka, kdeconnect, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180811/6a85079c/attachment.html>