D14597: [WIP] Get rid of DownloadJob

[Albert Vaca Cintora]

albertvaka accepted this revision.
albertvaka added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> notificationslistener.cpp:272
>              np.setPayload(iconSource, iconSource->size());
> +        qDebug() << "Set setPayload";
>      }

Remove qDebug

> sendfiletest.cpp:126
>              QCOMPARE(ft->error(), 0);
> -            QCOMPARE(spyDownload.count(), 1);
> -            QCOMPARE(spyUpload.count(), 1);
> +            //QCOMPARE(spyUpload.count(), 1);
>  

Have you figured out why this signal is not being emitted? Can you add a comment explaining why, or at least saying "HACK: breaks test if uncommented"?

REPOSITORY
  R224 KDE Connect

BRANCH
  arcpatch-D14597

REVISION DETAIL
  https://phabricator.kde.org/D14597

To: nicolasfella, #kde_connect, albertvaka
Cc: albertvaka, kdeconnect, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180807/58c34d15/attachment.html>