D14568: Fixup the sfos mpris control

[Aleix Pol Gonzalez]

apol added a comment.


  In any case, feel free to push directly to the sfos parts of kdeconnect, I don't think we have the know-how in the team to review properly.
  Also feel free to find someone who knows sailfish to review, that would work as well.

INLINE COMMENTS

> mpris.qml:37
>              pluginInterface.requestPlayerList();
> +            sldVolume.value = root.pluginInterface.volume;
>          }

Usually using the declarative API is better.

> mpris.qml:57
>          }
> -        Row {
> +        Item {
>              width: parent.width

Maybe use RowLayout?

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D14568

To: piggz, #kde_connect, nicolasfella
Cc: apol, kdeconnect, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180802/4a302ede/attachment-0001.html>