D12546: Support multiple players in MprisRemote

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Apr 27 10:06:06 UTC 2018


apol added a comment.


  Other than that looks good to me. Thanks!

INLINE COMMENTS

> mprisremoteplugin.cpp:206
> +{
> +    if (m_currentPlayer.isEmpty())
> +        return QString();

While this will work, if the map ever gets out of sync we could get a crash.

Maybe it's just safer to do something like:

  auto player = m_players.value(m_currentPlayer);
  return player ? player->album() : QString();

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D12546

To: nicolasfella, #kde_connect
Cc: apol, #kde_connect, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ahmedbesbes, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180427/27e06d6b/attachment.html>


More information about the KDEConnect mailing list