D12281: Enable (de)selecting all apps in notification filter

Matthijs Tijink noreply at phabricator.kde.org
Sat Apr 21 18:00:58 UTC 2018


mtijink added inline comments.

INLINE COMMENTS

> nicolasfella wrote in NotificationFilterActivity.java:203
> The database operation is quite expensive. Previously only one item at a time was updated so it was only very short. Now all items are updated at once resulting in a noticeable lag when done in the UI thread

Can't we do something like `UPDATE checked = false` (like in SQL)? So only one query for all checks at once.

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D12281

To: nicolasfella, #kde_connect, broulik
Cc: mtijink, broulik, #kde_connect, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ahmedbesbes, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180421/bd7c875e/attachment.html>


More information about the KDEConnect mailing list