D9691: Add contacts-reading plugin (KDE side)

[Aleix Pol Gonzalez]

apol added a comment.


  Patch looks good to me, I'd say let's merge it so we can start testing.

INLINE COMMENTS

> sredman wrote in contactsplugin.h:122
> The future is uncertain... Maybe someone wants to make a BetterContactsPlugin which supports more packets but lives alongside this plugin? I don't see any reason to stop them.

Well that's not a great reason. If we ever need more abstraction we'll have to modify the code, and that's fine.
I'm not concerned about this though.

Note that public before Q_SIGNAL it does nothing and can be removed.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D9691

To: sredman, #kde_connect, apol
Cc: mtijink, #kde_connect, apol, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ahmedbesbes, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180418/98531f61/attachment-0001.html>