D11854: (WIP) Upgrade Telephony plugin to read SMS history (KDE side)

Tue Apr 17 20:03:38 UTC 2018

nicolasfella added a comment.

  Not sure if I'm overly nitpicky here 😆

  Will a message be always constructed from a QVariantMap? If not it would make more sense to ask for the actual parameters. To avoid code duplication one could make a helper method like

    Message Message::fromQVariant(QVariant args) {}

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D11854

To: sredman, #kde_connect, nicolasfella
Cc: nicolasfella, #kde_connect, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ahmedbesbes, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180417/e10e22e1/attachment.html>