D12293: Add actions to notifications

[Matthijs Tijink]

mtijink added inline comments.

INLINE COMMENTS

> notification.cpp:114
> +    connect(m_notification, QOverload<unsigned int>::of(&KNotification::activated), this, [this] (unsigned int actionIndex) {
> +        Q_EMIT actionTriggered(m_internalId, m_actions[actionIndex]);
> +    });

Do we need a check/index change here when we add "Reply" here?

> notification.cpp:204
> +
> +    qCDebug(KDECONNECT_PLUGIN_NOTIFICATION()) << np.get<QJsonArray>(QStringLiteral("actions"));
> +

Leftover debug?

> notificationsdbusinterface.h:55
>      Q_SCRIPTABLE void sendReply(const QString& replyId, const QString& message);
> +    Q_SCRIPTABLE void sendAction(const QString& key, const QString& action);
>  

I think `key` should be `replyId` or something like that.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D12293

To: nicolasfella, #kde_connect
Cc: mtijink, #kde_connect, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ahmedbesbes, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180417/65e39d12/attachment.html>