D12232: Simplify failed plugin list creation
Matthijs Tijink
noreply at phabricator.kde.org
Mon Apr 16 15:11:17 UTC 2018
mtijink added inline comments.
INLINE COMMENTS
> DeviceFragment.java:330
> - Log.e("DeviceActivity", "ConcurrentModificationException");
> - this.run(); //Try again
> }
You removed the retry code. Does that make sense? (ie never fired, or retries happen anyway?)
> PluginSmallEntryItem.java:25
> +
> +class PluginSmallEntryItem extends SmallEntryItem {
> +
What does this name mean? I'd pick something clearer, although that seems hard in this case.
REPOSITORY
R225 KDE Connect - Android application
REVISION DETAIL
https://phabricator.kde.org/D12232
To: nicolasfella, #kde_connect
Cc: mtijink, #kde_connect, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ahmedbesbes, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180416/f7280b73/attachment.html>
More information about the KDEConnect
mailing list