D11684: Show the KCM with the run commands open when a setup packet is received

[Nicolas Fella]

nicolasfella added inline comments.
Restricted Application added a project: KDE Connect.

INLINE COMMENTS

> runcommandplugin.cpp:72
> +    } else if (np.has("setup")) {
> +        QProcess::startDetached(QStringLiteral("kcmshell5"), {QStringLiteral("--args"), QString(device()->id() + QStringLiteral(":kdeconnect_runcommand")) });
>      }

Why not separate by space instead of ':'? Would simplify the logic above

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D11684

To: apol, #kde_connect
Cc: nicolasfella, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ahmedbesbes, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180414/dff03fb9/attachment.html>