D12153: Fix receiving payloads using a bluetooth connection

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> bluetoothdownloadjob.cpp:38
>  {
> -    connect(mSocket.data(), SIGNAL(disconnected()), this, SLOT(deleteLater()));
> +    connect(mSocket.data(), &QBluetoothSocket::disconnected, mSocket.data(), &QBluetoothSocket::readyRead);
> +    connect(mSocket.data(), &QBluetoothSocket::disconnected, mSocket.data(), &QBluetoothSocket::readChannelFinished);

Will it still get deleted now?

> filetransferjob.cpp:44
> +    //Disabled this assert: QBluetoothSocket doesn't report "->isReadable() == true" until it's connected
> +    //Q_ASSERT(m_origin->isReadable());
>      if (m_destination.scheme().isEmpty()) {

Just remove it, or do a `|| is bluetooth somehow`.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D12153

To: mtijink, #kde_connect
Cc: apol, #kde_connect, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180413/4290e72d/attachment.html>