D12070: Fix default Find My Phone ringtone

Matthijs Tijink noreply at phabricator.kde.org
Mon Apr 9 16:06:27 UTC 2018


mtijink created this revision.
mtijink added a reviewer: KDE Connect.
Restricted Application added a project: KDE Connect.
mtijink requested review of this revision.

REVISION SUMMARY
  Previously, if the user hadn't set a ringtone, the code raised an exception (because an empty string isn't an uri). Thus, no sound was played.
  
  This fixes it.
  
  BUG: 392853

TEST PLAN
  Without having set a ringtone, it works. Otherwise, it works too.

REPOSITORY
  R225 KDE Connect - Android application

BRANCH
  fix-default-findmyphone

REVISION DETAIL
  https://phabricator.kde.org/D12070

AFFECTED FILES
  src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhoneActivity.java

To: mtijink, #kde_connect
Cc: #kde_connect, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180409/1e7e8561/attachment.html>


More information about the KDEConnect mailing list