D7992: WIP: Add systemvolume plugin

Nicolas Fella noreply at phabricator.kde.org
Tue Sep 26 10:59:04 UTC 2017


nicolasfella created this revision.
nicolasfella added a reviewer: KDE Connect.
nicolasfella added a project: KDE Connect.

REVISION SUMMARY
  This plugin allows controlling the system value from a remote device. It works pretty well except for the following issues:
  
  - if multiple audio sinks are available only the one returned by @DEFAULT_SINK@ can be controlled
  - the remote device won't know if the user changes the volume in another way
  
  While the first one can be easily fixed by adding a volume slider for each sink there is no easy fix for the second, because there is no commad like get-sink-volume in pactl. I already filed a bug about this https://bugs.freedesktop.org/show_bug.cgi?id=102998 . We either have to wait until this gets fixed (maybe I will write a patch myself) or use libpulse directly, which would our work more complex.
  
  Though unfinished I'm showing it to get some early feedback. See corresponding Android patch

TEST PLAN
  Apply Android patch, open up MPRIS Activity and play with the slider

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D7992

AFFECTED FILES
  plugins/CMakeLists.txt
  plugins/systemvolume/CMakeLists.txt
  plugins/systemvolume/README
  plugins/systemvolume/kdeconnect_systemvolume.json
  plugins/systemvolume/systemvolumeplugin.cpp
  plugins/systemvolume/systemvolumeplugin.h

To: nicolasfella, #kde_connect
Cc: #kde_connect, daniel.z.tg, jeanv, tfella, seebauer, bugzy, progwolff, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170926/cfd99281/attachment.html>


More information about the KDEConnect mailing list