D7652: Prepare for better broadcast/neighbor detection

[Daniel Tang]

daniel.z.tg planned changes to this revision.
daniel.z.tg added a comment.


  I plan on fully moving `isOnMobileNetwork()` to `getNetworkBroadcastDestinations()`. This is because `isOnMobileNetwork()` currently prevents the "255.255.255.255"-destined packet from being sent from `LanLinkProvider`, but subnet-specific destinations from `getNetworkBroadcastDestinations()` are will only be found when we will want to use them. If no destinations are discovered, then behavior will be similar to when `isOnMobileNetwork() == true`. In the GUI, the message could be changed from "you are on a mobile data connection" to something like "It looks like you aren't connected to any compatible networks. Try connecting to a local network."
  
  Most of the changes to 'NetworkHelper' are for temporary debugging. The list of addresses that will be used and where they come from is being debugged. Also, I don't think `android.permission.ACCESS_WIFI_STATE` will be needed when `getNetworkBroadcastDestinations()` is done.

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D7652

To: daniel.z.tg, #kde_connect
Cc: albertvaka, daniel.z.tg, jeanv, tfella, aboudhar, seebauer, bugzy, progwolff, MayeulC, menasshock, ach, apol, hkaelberer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170902/ac233388/attachment.html>