D7209: Fix Notifications in Plasmoid

[Aleix Pol Gonzalez]

apol added a comment.


  Otherwise looks good to me

INLINE COMMENTS

> notification.cpp:153
> +    //HACK The only way to display no icon at all is trying to load a non-existant icon
> +    m_notification->setIconName(QString("not_a_real_icon"));
> +}

QStringLiteral

> notificationsdbusinterface.cpp:148
>      if (!noti) {
> -        qCDebug(KDECONNECT_PLUGIN_NOTIFICATION) << "Not found noti by public Id: " << publicId;
> +        //qCDebug(KDECONNECT_PLUGIN_NOTIFICATION) << "Not found noti by public Id: " << publicId;
>          return;

Unrelated change, remove before committing.

> notificationsdbusinterface.cpp:153
>      //Deleting the notification will unregister it automatically
> -    //QDBusConnection::sessionBus().unregisterObject(mDevice->dbusPath()+"/notifications/"+publicId);
> +    //QDBusConnection::sessionBus().unregisterObject(mdevice->dbusPath()+"/notifications/"+publicId);
>      noti->deleteLater();

Unrelated change, remove before committing.

> notificationsdbusinterface.h:42
>  public:
> +
>      explicit NotificationsDbusInterface(KdeConnectPlugin* plugin);

Unrelated change, remove before committing.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D7209

To: nicolasfella, #kde_connect, apol
Cc: albertvaka, broulik, apol, #kde_connect, ahmedbesbes, daniel.z.tg, jeanv, tfella, seebauer, bugzy, progwolff, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20171101/8d88fae3/attachment.html>