D6039: No need to use a QBuffer in DownloadJob

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> apol wrote in downloadjob.cpp:74
> qCWarning(KDECONNECT_CORE)

Not what was used, but i can improve it if you want.

> apol wrote in downloadjob.cpp:87
> Why do we need to emit upon `connected`?

Because it's when you can start using the socket iodevice.

> apol wrote in filetransferjob.cpp:82
> don't put?

as in

  mReply = Daemon::instance()->networkAccessManager()->put(req, mOrigin.data());

that is 12 lines lower in this file

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D6039

To: aacid, apol, albertvaka
Cc: #kde_connect
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170530/f08acd2a/attachment.html>