D5993: These changes allow replying to any notifications that offer quick reply text fields

Sat May 27 21:45:48 UTC 2017

apol added inline comments.

INLINE COMMENTS

> notification.cpp:147
>      mPayloadHash = np.get<QString>(QStringLiteral("payloadHash"));
> +    mRequestReplyId = np.get<QString>(QStringLiteral("requestReplyId"), QStringLiteral(""));
>  }

QString() to create an empty string.

> notificationsdbusinterface.cpp:37
>      , mPlugin(plugin)
> +    , m_telepathyInterface(QStringLiteral("org.freedesktop.Telepathy.ConnectionManager.kdeconnect"), QStringLiteral("/kdeconnect"))
>      , mLastId(0)

Why do you need telepathy here? This looks like it belongs to the telephony plugin

> sendsmsdialog.h:31
> +
> +class SendSmsDialog : public QDialog
> +{

Rename the dialog? Maybe make generic?

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D5993

To: progwolff, #kde_connect
Cc: apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170527/0d8289eb/attachment-0001.html>