D5941: Code refactoring, commening, and implement enough to have kdeconnect show as an option when adding an account!

[Aleix Pol Gonzalez]

apol added a comment.


  Other than that, LGTM.
  I'm not all that into telepathy connection managers though.

INLINE COMMENTS

> CMakeLists.txt:16
>  
> -add_executable(connectcm
> +add_executable(${PROJECT_NAME}
>      main.cpp

Ugh no, don't do that. Rename it if you want, but don't pass the name with a variable.
Better be explicit.

> connection.cpp:175
> + * @param identifies A list of contacts to add
> + */
>  Tp::UIntList ConnectConnection::requestHandles(uint handleType, const QStringList &identifiers, Tp::DBusError *error)

You added one comment in the cpp and the other on the header. Please do the same on both.

REPOSITORY
  R716 Telepathy KDE Connect Integration

REVISION DETAIL
  https://phabricator.kde.org/D5941

To: sredman, kdeconnect
Cc: apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170523/7353f78c/attachment.html>