D5876: Android 6 Runtime Permissions

[Nicolas Fella]

nicolasfella added a comment.


  In https://phabricator.kde.org/D5876#110318, @albertvaka wrote:
  
  > Thanks for starting to work on this! I find your approach to not be very user-friendly, though. Since the app only requests the permission after receiving a packet from the computer, if the user is not looking at the phone, it's easy to miss the popup.
  >
  > I think that we can do something more similar to the Notifications plugin: check if we have the permission when the plugin is instantiated (that is: after pairing) and if it's not, the initialization function returns false and we will list it on the main screen as "disabled/not working plugins". Then, when the user taps the plugin we show a popup explaining the reason we couldn't load the plugin (we don't have enough permissions) and from there we open the permission request. When you have given permissions, the plugin can load safely.
  >
  > Can you check how it is done for the Notifications plugin and try something similar?
  
  
  Actually it works this way: When the Main Activity is started the user is asked to grant the Permissions for Storage, Contacts, Phone and SMS. When something happens that needs a permission it checks whether we have this permission. If not, nothing happens. You're right, thats not very user friendly because the user doesn't know why some features are not working when he/she declines a permission. I think that not loading a plugin because of lack of permission is not wise as some plugins are useful even without them (e.g. the SharePlugin can still share/receive URLs without the storage permission).
  
  Our first task should be identifying all the spots where certain permissions are required and make the programm not to crash when a permission is not granted.
  Then we should notify the user if some features are disabled because of lack of permission

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D5876

To: nicolasfella, #kde_connect
Cc: albertvaka, seebauer, MayeulC, menasshock, ach, apol, hkaelberer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170517/8e8e2db7/attachment.html>