Review Request 130050: Notification improvements

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130050/#review102959
-----------------------------------------------------------




plugins/notifications/notification.cpp (line 47)
<https://git.reviewboard.kde.org/r/130050/#comment68524>

    No need to initialize to "", this will allocate memory for no reason, we know it's empty.



plugins/notifications/notification.cpp (line 54)
<https://git.reviewboard.kde.org/r/130050/#comment68523>

    Use `mTitle.isEmpty()`



plugins/notifications/notification.cpp (line 63)
<https://git.reviewboard.kde.org/r/130050/#comment68526>

    Coding style. Spaces around braces.



plugins/notifications/notification.cpp (line 67)
<https://git.reviewboard.kde.org/r/130050/#comment68525>

    .isEmpty()


- Aleix Pol Gonzalez


On mar. 26, 2017, 8:58 p.m., Nicolas Fella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130050/
> -----------------------------------------------------------
> 
> (Updated mar. 26, 2017, 8:58 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Notification icons are now displayed if Desktop and Android App support it both. Filetransferjob is now nonblocking and files are stored based on the images MD5. Some improvements in displaying the notification, e.g. Title is only displayed when different to the App Name. Most of the notification display code has moved to the notification class
> 
> 
> Diffs
> -----
> 
>   .gitignore d7f2d6068b0ecfc20040c84b268299895de4c519 
>   core/filetransferjob.h a94b38c0b39961471575e815acc8daaa43f2a7ad 
>   plugins/notifications/notification.h 39a73ea435b571046d7f65909afc63470d4026b7 
>   plugins/notifications/notification.cpp 487ca84fc1d5417aedda8509545eee5da8d6c03f 
>   plugins/notifications/notificationsdbusinterface.h b8120f661925a350109a55014eb62141f395d22f 
>   plugins/notifications/notificationsdbusinterface.cpp dbd63099f7fd41aeb730cbda78036888ef1a5a18 
> 
> Diff: https://git.reviewboard.kde.org/r/130050/diff/
> 
> 
> Testing
> -------
> 
> Tested with Plasma 5.9.3 (Manjaro)
> Tested with patched Android + patched KDE, unpatched Android + patched KDE, patched Android + unpatched KDE from Manjaro repo
> 
> 
> Thanks,
> 
> Nicolas Fella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170327/77ec3391/attachment.html>